Skip to content

Always report run-time errors as the sole reply #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2021
Merged

Always report run-time errors as the sole reply #1590

merged 3 commits into from
Feb 24, 2021

Conversation

jeffreylovitz
Copy link
Contributor

Resolves #1585

This PR additionally removes the behavior of emitting run-time errors as the last element of the result; they will instead be the entire result.

Old behavior:

GRAPH.QUERY G "MERGE (a {v: NULL}) RETURN a"
1) 1) "a"
2) (empty array)
3) (error) Cannot merge node using null property value

New behavior:

GRAPH.QUERY G "MERGE (a {v: NULL}) RETURN a"
(error) Cannot merge node using null property value

@jeffreylovitz jeffreylovitz self-assigned this Feb 23, 2021
swilly22
swilly22 approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@swilly22 swilly22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work!

@swilly22 swilly22 merged commit c9ba776 into master Feb 24, 2021
@swilly22 swilly22 deleted the no-partial-results-on-runtime-error branch February 24, 2021 09:43
@jeffreylovitz jeffreylovitz mentioned this pull request Feb 24, 2021
Merged
jeffreylovitz added a commit that referenced this pull request Feb 25, 2021
@jeffreylovitz @swilly22
Always report run-time errors as the sole reply (#1590)
207030d 
* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
jeffreylovitz added a commit that referenced this pull request Mar 10, 2021
@jeffreylovitz @swilly22
Always report run-time errors as the sole reply (#1590)
0ec6806 
* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit c9ba776)
swilly22 added a commit that referenced this pull request Mar 15, 2021
@jeffreylovitz @swilly22
@filipecosta90 @odanoburu @rafie
2 2 16 upversion (#1621)
e611266 
* RedisGraph benchmark automation  (#1557)

* Added local and remote benchmark definition and automation

* [fix] Fixes per PR review. Added option to specify benchmark via BENCHMARH=<benchmark name>. Updated benchmark template

Co-authored-by: filipecosta90 <filipecosta.90@gmail.com>
(cherry picked from commit f6f1ab2)

* Updated benchmark UPDATE-BASELINE to be less restrictive in the latency KPI (#1577)

Given we're still experimenting with the benchmarks CI KPI validation, this PR increases the `OverallClientLatencies.Total.q50` to be lower than 2.0 ( before was 1.5 ) so that we can collect further data and adjust afterwards...

(cherry picked from commit 611a0f0)

* * log redisgraph version (#1567)

When pulling container image tagged as `latest` or `edge` I sometimes
don't know which version I'm running, and it would be much faster to
find out if the information was displayed at startup. This patch logs
this information.

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit fe2e7ce)

* [add] Triggering nightly CI benchmarks; Early return on CI benchmarks for forked PRs (#1579)

(cherry picked from commit a529c1e)

* use PRIu64 to format uint64_t (#1581)

(cherry picked from commit c0e00d5)

* [fix] Fixed missing github_actor on ci nightly benchmark automation (#1583)

(cherry picked from commit 8abad84)

* Fix idx assertion (#1580)

* Fix flawed assertion in index deletion logic

* Reduce KPI for updates_baseline benchmark

* Address PR comments

* Address PR comments

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 6bad20a)

* Always report run-time errors as the sole reply (#1590)

* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit c9ba776)

* remove wrong assertion (#1591)

(cherry picked from commit 12ef8ac)

* Report 0 indices created on duplicate index creation (#1592)

(cherry picked from commit e00f2c8)

* Multi-platform build (#1587)

Multi-platform build

(cherry picked from commit 26ace7a)

* Multi-platform build, take 2 (#1598)

(cherry picked from commit acde693)

* Moved common benchmark automation code to redisbench-admin package. Improved benchmark specification file (#1597)

(cherry picked from commit ebea927)

* Added readies submodule (#1600)

* Added readies submodule

* fixes 1

(cherry picked from commit efbfeaf)

* Dockerfle: fixed artifacts copy (#1601)

(cherry picked from commit f722f2d)

* CircleCI: fixed version release (#1602)

(cherry picked from commit 9f218d6)

* CircleCI: release-related fix (#1604)

(cherry picked from commit 15cf291)

* remove redundent include (#1606)

(cherry picked from commit 7ea1c43)

* Threaded bulk insert (#1596)

* Update the bulk updater to execute on a thread

* Bulk loader endpoint locks for minimal time

* TODOs

* Use a separate thread pool for bulk operations

* Update test_thread_pools.cpp

* refactor bulk-insert

* Fix PR problems

* count number of pings during bulk-insert, only create graph context on BEGIN token

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 2d43f9d)

* Use system gcc in Ubuntu 16 (#1615)

(cherry picked from commit 0c10130)

* wrongly assumed add op had only 2 operands (#1618)

(cherry picked from commit 6b06095)

* Updated benchmark requirements version (#1616)

* Updated benchmark requirements version

* Update requirements.txt

(cherry picked from commit db080d4)

* Runtime timeouts (#1610)

* Add run-time configuration for default query timeouts

* Timeout for write queries that haven't committed changes

* define TIMEOUT_NO_TIMEOUT

* Refactor timeout logic

* Address PR comments

* Do not use timeouts for write queries

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
(cherry picked from commit 964b268)

* Fix typo in assertion

* bump version to 2.2.16

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
Co-authored-by: bc² <odanoburu@users.noreply.github.com>
Co-authored-by: Rafi Einstein <raffapen@outlook.com>
swilly22 added a commit that referenced this pull request Nov 16, 2021
@AviAvni @swilly22
@jeffreylovitz @leibale @whitewum @LiorKogan @chayim @gkorland @filipecosta90
Update 2.8 (#2034)
dcf187f 
* WIP

* WIP

* Add flow test

* Reintroduce OpUpdate

* Pass test suite

* Fix memory leak

* Update serialization routines

* Address PR comments

* Use macro for retrieving labels

* Address PR comments

* use mkdocs-modules-template (#1586)

* Fix idx assertion (#1580)

* Fix flawed assertion in index deletion logic

* Reduce KPI for updates_baseline benchmark

* Address PR comments

* Address PR comments

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* Always report run-time errors as the sole reply (#1590)

* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* remove wrong assertion (#1591)

* Address PR comments

* Fix label matrix resizing

* Increment encoding version

* query graph node refactoring

* sync node_labels to (node_cap X lbl_count) dim

* avoid unnecessary lock

* a bit of tests refactoring

* re-enable unit tests

* Post-merge fixes

* Add support for multiple labels in bulk loader

* Post-merge fixes

* fix build

* fix submodule issue

* fix _Graph_LabelNode

* fix matrix resize

* fix build

* make test readable

* review

* fix apply all pending

* build node_labels matrix from label matrices

* move iter to stack

* update RediSearch

* implement index specific fields

* add tests

* fix build

* address review

* refactor

* refactor

* clean

* add tests

* add language and stopword output to db.indexes

* update test

* add documentation

* save index schema in rdb

* add test

* Resize label mapping matrix when creating nodes

* update redisearch

* use new api

* Flush all matrices on RDB load

* update redisearch

* use new api

* review changes [WIP]

* review changes [WIP]

* update RediSearch

* review changes [WIP]

* review changes [WIP]

* More extensive testing for multi-label support

* review changes [WIP]

* optimize starting point doc

* Track node count per label in graph statistics

* Address PR comments

* optimize label scan WIP

* optimize label scan WIP

* test multi-label label scan optimization

* Post-merge fixes

* Use new param style when invoking redisgraph-py from tests (#1953)

(cherry picked from commit 79c2edf)

* adding optimize_label_scan.c

* switch to graph statistics

* return zero matrix on no,unknown label

* Use indexed label with lowest NNZ in multi-label case

* WIP

* Fix AlgebraicExpression rewrite logic for multi-label

* Fix memory leaks

* simplifications

* Add documentation

* Additional multi-label bulk insert tests

* simplify algebraic expression src, dest operand locating

* update encoder to v10

* fix tests

* fix memory issue

* free stopwords

* free each stopword

* fix encoder

* fix memory leak

* Update commands.md

* stopwods only for full text index

* fix memory leak

* add tck test

* Update commands.md

Redundant double quotes removed.

* address review

* fix Env usage (#1998)

* Edge indexing (#1972)

* rename index_scan to node_by_index_scan

* getter apis for node, edge and schema

* introduce edge by index scan op

* specify index schema type when creating or deleting an index

* index specifies entity type

* index node, edge seperation

* index created edges

* update index upon edge deletion

* edge by index scan WIP

* WIP

* extend utilize indices to use edge indices

* add filter by source node

* introduce implicit index fields

* update edge index

* fix merge op

* fix for edge without alias

* fix merge

* use Schema_GetID

* add edge to record after update src and dest nodes

* fix edge index decoder

* db.indexes list ege indexes

* handle src and dst aware

* fix src dest aware implementation

* add review

* Add parser support for CREATE INDEX FOR syntax

* handle new index syntax

* fix prop name extract

* test index creation

* filter dest node and add tests

* add entity type to db.indexes

* update id before cloning the filter

* initialize yield_entity_type

* add documentation

* fix memory issue

* fix children aware and add tests

* check for child record

* add update index tests

* address review

* address review

* fix comment

* fix filter other node

* addres review

* utilize index has labels with multi label

* no need to change v9 decode

* add delete index tests

* fix comment

* address review

* space

* clean tests

* fix comment

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>

* Update References.md (#1997)

SlideShare link fixed

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* fix crash in utilize index using wrong query_graph (#2002)

* platform suffix on arm (#2003)

* platform suffix for arm

* readies latest for graph arm tag fix

* tying docs builds to 3.9 until mkdocs is upgraded (#2001)

* GraphBLAS 5.1.9 (#2007)

* disable GraphBLAS mempool if OpenMP is missing

* GraphBLAS V5.1.8

* add static_only rule

* remove unsused types and operations

* GraphBLAS V5.1.8 tests pass

* GraphBLAS V5.1.9

* remove memory-pool openmp disable

* GraphBLAS V5.1.10 (#2010)

Co-authored-by: swilly22 <roi@redislabs.com>

* update label for every node in ast (#2014)

* update label for every node in ast

* add comment for the test

* Update test_multi_label.py

* address review

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>

* commands.json (#1964)

Co-authored-by: Guy Korland <gkorland@gmail.com>

* Update README.md

* Update README.md

* Running only performance CI on integration branches (#2026)

* update redisearch to 2.0.13 (#2032)

Co-authored-by: swilly22 <roi@redislabs.com>
Co-authored-by: Jeffrey Lovitz <jeffrey.lovitz@gmail.com>
Co-authored-by: Leibale Eidelman <leibale1998@gmail.com>
Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Co-authored-by: min.wu <50101159+whitewum@users.noreply.github.com>
Co-authored-by: Lior Kogan <koganlior1@gmail.com>
Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Guy Korland <gkorland@gmail.com>
Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
@jeffreylovitz @swilly22
Always report run-time errors as the sole reply (RedisGraph#1590)
5862bf2 
* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
pnxguide pushed a commit to CMU-SPEED/RedisGraph that referenced this pull request Mar 22, 2023
@jeffreylovitz @swilly22
Always report run-time errors as the sole reply (RedisGraph#1590)
08094a8 
* Always report run-time errors as the sole reply

* Update test_timeout.py

Co-authored-by: Roi Lipman <swilly22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@swilly22 swilly22 swilly22 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jeffreylovitz jeffreylovitz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't emit any results on run-time errors
2 participants
@jeffreylovitz @swilly22