-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert servicemonitor #1250
Convert servicemonitor #1250
Conversation
c03c5b6
to
4fbdad0
Compare
70e675c
to
fdead49
Compare
@alejandroEsc could you clean up the commit history? Looks like you've pulled in a few things from |
8c2fec9
to
e0f8248
Compare
maybe i did, but i had not even rebased when those showed up, not sure what happened |
e0f8248
to
789ee53
Compare
789ee53
to
06a62d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, there's one missing part here 😓 Sorry there's not great documentation here.
You'll need to modify the original servicemonitor.yaml
to instead call out to the go function. There's not currently support for marking a function as an "entrypoint" or anything like that. service.nodeport.yaml
has an example of what that looks like.
Could we also add some more tests for this by creating some novalues.yaml
files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like you'll need to run go mod tidy
in the testdata
directory and you've got an interesting test failure that I'm not immediately recognizing.
closing in favor of #1313 |
Done, generating code is working.