pkg/helm: run helm template directly instead of via subprocess
#1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/p/helm-in-process
branch
from
772924d
to
b705eab
Compare
chrisseto
changed the title
helm template directly instead of via subprocess
chrisseto
force-pushed
the
chris/p/helm-in-process
branch
2 times, most recently
from
655f3ac
to
e4894ad
Compare
c4milo
reviewed
May 20, 2024
| client.GenerateName = opts.GenerateName | ||
| client.Namespace = opts.Namespace | ||
| client.ReleaseName = opts.Name | ||
| client.Replace = true // Skips "name" checks. |
There was a problem hiding this comment.
are we sure we want this default value in production?
There was a problem hiding this comment.
This is borrowed directly from helm itself. helm template needs to run in an isolated environment. Rather than having that logic baked in, they opted to use this as a work around. I'll add a back link and a note saying as much. I could have sworn that I had a few links peppered in there already but looks pretty scant.
RafalKorepta
approved these changes
May 22, 2024
RafalKorepta
force-pushed
the
chris/p/helm-in-process
branch
from
e4894ad
to
e4146b4
Compare
RafalKorepta
force-pushed
the
chris/p/helm-in-process
branch
from
e4146b4
to
9f05fc5
Compare
chrisseto
force-pushed
the
chris/p/helm-in-process
branch
from
9f05fc5
to
de8d769
Compare
This commit modifies helm.Client.Template to run via depending on Helm as a library rather than run through a subprocess. This provides a greater degree of control over the helm execution environment but also reduces the overhead of running `helm template` many times. Note: The actual performance gain of this commit hasn't truly been measured. The bulk of the time was wasted in `deepCopy` calls, this commit was required to appropriately profile the execution of `helm template`.
chrisseto
force-pushed
the
chris/p/helm-in-process
branch
from
de8d769
to
89440d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b705eab pkg/helm: run
helm templatedirectly instead of via subprocessThis commit modifies helm.Client.Template to run via depending on Helm as a
library rather than run through a subprocess. This provides a greater degree of
control over the helm execution environment but also reduces the overhead of
running
helm templatemany times.Note: The actual performance gain of this commit hasn't truly been measured.
The bulk of the time was wasted in
deepCopycalls, this commit was requiredto appropriately profile the execution of
helm template.