Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates controller gen tool to version
0.15.0
. With go 1.22.2 and 1.22.3 I was getting crash when generating code. It seems related to either kubernetes-sigs/controller-tools#880 or kubernetes-sigs/controller-tools#851. If I use to go version 1.21.10 it seems to work. Or if I update to version0.14.0
or0.15.0
of controller gen. This did change the YAML formatting of the manifests.Updates testcontainers and redpanda module to version
0.29.1
. This was needed due to some fixes for better support of non-Docker container runtimes like Podman and Rancher Desktop. Particularly there were fixes in the Redpanda module as well to improve support for these.The version picked is due to testcontainers/testcontainers-go#2477 which causes issues with using
0.30.0
version.As a result of updating testcontainers I needed to update
oras.land/oras-go
for some reason, as I was getting the following errors:Now
k8s:run-unit-tests
passes locally for me.