Replies: 1 comment 1 reply
-
Other things to note:
|
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When running
rpk redpanda tune <tuner>
we have 3 states:1. Applied: Tuner was successfully applied after running rpk tune .
2. Enabled: Tuner is enabled via redpanda.yaml configuration properties.
3. Supported: Tuner is supported in the system in which redpanda is running.
In #5186 we noticed that
rpk redpanda tune
always exits with code 0, it doesn't matter if the runner was applied, enabled, or supported.In #5295 we fixed this by making
rpk redpanda tune <tuner>
exit with code 1 when: Tuner failed OR Tuner is enabled but unsupported.This raised different questions:
rpk redpanda mode production
includesdisk_write_cache
tuner, which is only supported for GCP and will fail in non-gcp environments. Should we take this tuner off of production mode or allow it to fail (temporary fix in rpk: allow write_disk_cache to fail in rpk tune #5348)Beta Was this translation helpful? Give feedback.
All reactions