Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] transform: prevent double processor starts #15941

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[v23.3.x] transform: prevent double processor starts #15941

merged 2 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. transform/processor: prevent double start 

    There is an edge case when the wasm VM immediately halts that we can get
double starts because the task is "failed", but that can cause something
else to come along in `transform::manager::start_processor` and start it
again, which messes up our ref counting in the shared wasm engine.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
(cherry picked from commit fb71461)
    @rockwotj @vbotbuildovich
    rockwotj authored and vbotbuildovich committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ce4696f View commit details
    Browse the repository at this point in the history

  2. transform/processor: protect against double starts 

    Double starts can mess up our ref counting as seen in the previous
commit. Guard against this in the future by mirroring stop and checking
the abort source.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
(cherry picked from commit 497785a)
    @rockwotj @vbotbuildovich
    rockwotj authored and vbotbuildovich committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ca3586d View commit details
    Browse the repository at this point in the history