[v23.3.x] transform: prevent double processor starts #15941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an edge case when the wasm VM immediately halts that we can get double starts because the task is "failed", but that can cause something else to come along in `transform::manager::start_processor` and start it again, which messes up our ref counting in the shared wasm engine. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit fb71461)
Double starts can mess up our ref counting as seen in the previous commit. Guard against this in the future by mirroring stop and checking the abort source. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 497785a)
rockwotj
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15933