[v23.3.x] Add partition aggregation to some metrics #16100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment explaining that compaction_ratio metric cannot be aggregated as it is a ratio, for which a sum is meaningless. (cherry picked from commit 1ab66f9)
When metrics aggregation is turned on, we want to aggregate away the partition labels on most metrics: this wasn't occurring in the consensus object for two metrics: leader_for and reconfiguration changes in progress. This change enable aggregation on the partition label for these metrics if aggregation is turned on. Issue redpanda-data#15811. Issue redpanda-data/core-internal#677. (cherry picked from commit 04b1535)
When metrics aggregation is turned on, we want to aggregate away the partition labels on most metrics: this wasn't occurring in the partition probe object. This change enable aggregation on the partition label for almost all metrics in the partition problem, with only two excluded: vectorized_cluster_partition_leader_id vectorized_cluster_partition_under_replicated_replicas Issue redpanda-data#15811. Issue redpanda-data/core-internal#677. (cherry picked from commit 27e6e2b)
When metrics aggregation is turned on, we want to aggregate away the partition labels on most metrics: this wasn't occurring in the tx metrics. This change enable aggregation on the partition label for almost all three metrics in this probe. Issue redpanda-data#15811. Issue redpanda-data/core-internal#677. (cherry picked from commit 65c0a89)
|
Manually opened this PR using the vbot branch because @vbotbuildovich is failing (see https://redpandadata.slack.com/archives/C02LZGSS66M/p1705084266254489) before subitting the PR (but after creating the branch with the backported content). |
StephanDollberg
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15966
Fixes #16093