Fix client state desync #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored server api to pass down a user object instead of uuid. This avoids redundant database calls, and is more declarative. `requireAuth` should be synonymous with `requireValidUser`.
nick-ls
pushed a commit
to nick-ls/rctf
that referenced
this pull request
Aug 6, 2024
Fix client state desync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #117
Note that this introduces (significant?) overhead in the form of an extra database call per API endpoint. This shouldn't be too big of an issue, as most endpoints result in a database call regardless, meaning that this should at most double request time.
We may want to more closely monitor the performance penalty incurred here though.