migrate to yarn 2 + batch dependency upgrade #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No package version changes, only Yarn 2 migration (without pnp)
A few majors held back for another commit, Prettier re-run; theme-ui was upgraded with a breaking deprecation that will be fixed in the next commit.
`useCustomProperties` is now under `theme.config`.
Fix CI and Docker build to use yarn 2 commands, run `yarn dedupe` on pre-commit and CI, and update a few more configs for yarn 2 paths and conventions.
Disable diffs and auto merging on vendored yarn code, disable diffs on yarn.lock, and remove .yarn/sdks from repo.
Merge in changes to Fastify request log serializer from upstream Fastify. This fixes a deprecation warning.
Instead of using the object returned by `render`, query using the global `screen` as recommended by Kent C. Dodds. https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-screen
Since the `getBy*` functions throw when they cannot find an element, prefer them for querying for elements that should exist (except when the test is explicitly for whether or not the element exists). This removes most of the null checks in the test code.
ethanwu10
force-pushed
the
dependencies/yarn-2-batch
branch
from
a9df047
to
a8318fc
Compare
Since yarn 2 uses an internal shell parser[1] which supports environment variables, we no longer need to use cross-env for cross-platform environment variable setting. [1]: https://github.com/yarnpkg/berry/tree/%40yarnpkg/shell%2F2.4.1/packages/yarnpkg-shell
Codecov Report
@@ Coverage Diff @@
## next #566 +/- ##
=======================================
Coverage 50.97% 50.97%
=======================================
Files 89 89
Lines 1542 1542
Branches 292 286 -6
=======================================
Hits 786 786
Misses 735 735
Partials 21 21
Continue to review full report at Codecov.
|
|
Storybook throws warnings but still starts; seems to be related to storybookjs/storybook#14805 Since it doesn't seem to affect anything, we can probably just merge as-is (I don't particularly want to add the manual babel plugin option override to suppress it since it's a storybook issue and doesn't exist in our normal webpack build). |
Fix .yarn being included twice, add dockerignore entries for yarn to hopefully prevent some churn (using the ignore list recommended for PnP zero-install).
ginkoid
approved these changes
May 10, 2021
When casting the handler functions exported from individual routes, derive the target type by inspecting the `route` method of the FastifyInstance we are registering them on. Since we adjust the instance type to better match `http.Server`, this fixes a type mismatch that appears when compiling on some platforms when trying to register the handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate yarn to yarn berry without PnP.
Batch dependency upgrade has no major production dependency upgrades. Tooling / dev dep major upgrades include Husky 6 (new hook executor) and AJV 8 (no significant changes). eslint dependencies have also all been hoisted to the project root.