Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for operators #32

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Conversation

stnokott
Copy link
Contributor

@stnokott stnokott commented Mar 15, 2023

Adds two tests:

When both of these succeed, we can be pretty certain that our data is complete.
The only uncertainty will be if the IDs in header.go match the replay files.

Closes #31


@redraskal
Let me know what you think about the added comment in genops.go:

// since we have a test validating that every operator has a role,
// it could be argued that this method does not need to return an error
// and instead could just panic if the role isnt found

@stnokott
Copy link
Contributor Author

Tests are failing due to #33

@stnokott stnokott marked this pull request as ready for review March 15, 2023 11:02
@redraskal
Copy link
Owner

I think panic is ok in that case

@stnokott
Copy link
Contributor Author

I think panic is ok in that case

I'll change that tomorrow, don't have any more time today.
Or just merge this now and I'll open a new PR for that change, whatever you prefer.

@redraskal
Copy link
Owner

I think panic is ok in that case

I'll change that tomorrow, don't have any more time today. Or just merge this now and I'll open a new PR for that change, whatever you prefer.

I'll just merge and make a release so everyone has functional Year 8 binaries

@redraskal redraskal merged commit c201ace into redraskal:main Mar 15, 2023
@stnokott stnokott deleted the test_roles_present branch March 17, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test if every operator has a role
2 participants