Simplify Operator.Role
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying
Operator.Roleto panic when unable to determine team role for an operator instead of returning an error.This is possible since we have a test in place verifying that each operator has a role assigned.
The only scenario where the function can panic if it is called on unitialized an
Operator(with value0).Since we only use
Operator.Roleinternally, we can assure this doesn't happen.While at it, I also added ordering for the source code of operator roles in 42c5f9e. I was irritated that the generation of the operator roles map wasn't deterministic, making it hard to
git diffthe changes, i.e. when a new operator is added.This is now possible.