RS-394: Add query support for browser #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atimin
requested changes
Aug 6, 2024
src/Record.ts
Outdated
| @@ -12,7 +13,7 @@ export class ReadableRecord { | |||
| public readonly time: bigint; | |||
| public readonly size: bigint; | |||
| public readonly last: boolean; | |||
| public readonly stream: Stream; | |||
| public readonly stream: Stream | ArrayBuffer; | |||
There was a problem hiding this comment.
I think you break the compatibility here, because in the client code the TS compiler will rise an error to force type check.
I think it is better to use two fields. We can even make it private.
There was a problem hiding this comment.
@atimin good point! I have added another private field for ArrayBuffer. The twist is to give a dummy stream to the stream field in the browser to avoid having an optional stream field that would break compatibility. Let me know if the new update makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
Related issues
No
Does this PR introduce a breaking change?
No
Other information:
Because the read function gives a Node.js Buffer object, applications running in the browser must install stream-browserify.