Remove no-resolution flag and add --exclude-entrypoints when running are-the-types-wrong during CI
#2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `@arethetypeswrong/cli` now has an `--exclude-entrypoints` flag which we can use to exclude the `alternate-renderers` entrypoint from the check since it will fail under the `Node10` module resolution as `Node10` looks at actual files on disk and we don't have a file named `alternate-renderers`.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
aryaemami59
force-pushed
the
attw-exclude-entrypoints
branch
from
a1ffc6e
to
d083422
Compare
|
Oh good! This was bugging me as a false positive. Thanks! |
|
Yep, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arethetypeswrong/clinow has an--exclude-entrypointsflag which we can use to exclude thealternate-renderersentrypoint from the check since it will fail under theNode10module resolution asNode10looks at actual files on disk and we don't have a file namedalternate-renderers.