Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scripts #12

Merged
merged 6 commits into from
Jul 3, 2020
Merged

Fix scripts #12

merged 6 commits into from
Jul 3, 2020

Conversation

nickserv
Copy link
Contributor

@nickserv nickserv commented Mar 11, 2020 •
edited

Ported from reduxjs/cra-template-redux#12

Fixes #9

  • prettify needs to be rerun
  • lint fails because of different Prettier options
  • test is missing and should be ported from cra-template-redux
  • type-check fails because there's no tsconfig

@nickserv nickserv changed the title Fix #9 Fix scripts Mar 11, 2020
@nickserv nickserv marked this pull request as ready for review March 12, 2020 04:14
@nickserv nickserv mentioned this pull request Mar 13, 2020
Closed
@msalahz
Copy link

msalahz commented Apr 11, 2020

Any updates about this?

@nickserv
Copy link
Contributor Author

Needs review

@aamirafridi
Copy link

Cannot wait for this PR :P
Can you add reviewers from the sidebar to send them notification?

@nickserv
Copy link
Contributor Author

I don't have permission to myself

@beenotung
Copy link

Can you add reviewers from the sidebar to send them notification?
I don't have permission to myself

I suppose we can notify the maintainer by tagging them like this: @timdorr

@timdorr
Copy link
Member

timdorr commented Jul 3, 2020

LGTM. Thanks!

@timdorr timdorr merged commit 78b5489 into reduxjs:master Jul 3, 2020
@nickserv nickserv deleted the fix-9 branch July 3, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type-check scripts doesn't work and lint reports many errors
5 participants
@nickserv @msalahz @aamirafridi @beenotung @timdorr