Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 2015 preset and add env #236

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

hozefaj
Copy link
Contributor

@hozefaj hozefaj commented Feb 5, 2019

Is there any requirement in setting a specific set of targets?

@timdorr
Copy link
Member

timdorr commented Jun 26, 2019

We should still target IE11 support. If not, I would argue that warrants a major bump.

@hozefaj
Copy link
Contributor Author

hozefaj commented Jun 26, 2019

@timdorr So what's the recommendation, I agree that dropping ie 11 support should warrant a major version bump.

But on the other hand, supporting ie11 also dings everyone else that use browsers that have over the air updates.

@timdorr
Copy link
Member

timdorr commented Jun 26, 2019

For the moment, I would include IE11. We can revisit the config for the next major release.

.babelrc Outdated
]
},
"presets": ["env"],
"targets": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hozefaj
Copy link
Contributor Author

hozefaj commented Jun 26, 2019

@timdorr I have added ie11 as a target. Also removed the lock file. Best that a new lock file is generated before a new version of the package is published.

@timdorr
Copy link
Member

timdorr commented Jun 26, 2019

No, please include the lock file. That shows exactly which deps to install.

@hozefaj
Copy link
Contributor Author

hozefaj commented Jun 26, 2019

No, please include the lock file. That shows exactly which deps to install.

Done, added the package.json-lock file to the PR

@timdorr
Copy link
Member

timdorr commented Jun 27, 2019

Excellent. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants