-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove 2015 preset and add env #236
Conversation
We should still target IE11 support. If not, I would argue that warrants a major bump. |
@timdorr So what's the recommendation, I agree that dropping ie 11 support should warrant a major version bump. But on the other hand, supporting ie11 also dings everyone else that use browsers that have over the air updates. |
For the moment, I would include IE11. We can revisit the config for the next major release. |
.babelrc
Outdated
] | ||
}, | ||
"presets": ["env"], | ||
"targets": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timdorr I have added |
No, please include the lock file. That shows exactly which deps to install. |
Done, added the |
Excellent. Thank you! |
Is there any requirement in setting a specific set of targets?