v1.7.0 integration branch #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 3fb4526 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6156c41a1043d200086cd762 😎 Browse the preview: https://deploy-preview-1565--redux-starter-kit-docs.netlify.app |
size-limit report 📦
|
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aad6d32:
|
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 18ef51d 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6156c48638a3b1000774e759 😎 Browse the preview: https://deploy-preview-1565--redux-starter-kit-docs.netlify.app |
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: aad6d32 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/61b3a131680b4266a2aab986 😎 Browse the preview: https://deploy-preview-1565--redux-starter-kit-docs.netlify.app |
Co-authored-by: Lenz Weber <lenz.weber@mayflower.de>
phryneas
force-pushed
the
v1.7.0-integration
branch
from
844299f
to
43bba18
Compare
…tableValue-addition
… `fixedCacheKey` (#1477)
Co-authored-by: Lenz Weber <mail@lenzw.de>
Co-authored-by: Josh Fraser <joshfraser91@gmail.com>
markerikson
force-pushed
the
v1.7.0-integration
branch
from
97a9f63
to
c455fc2
Compare
fetchBaseQuery: return `null` instead of `undefined` on empty body for JSON. Also add dev errors if `baseQuery`/`queryFn` returns a wrong shape (#1699)
Co-authored-by: Lenz Weber <mail@lenzw.de>
…1701) * Add unwrap to QueryActionCreatorResult and update LazyQueryTrigger * Add test for the return value of lazy query's trigger * Fix types for lazy query :fingers_crossed: * minor refactor, add test for positive case * Use QueryResultSelectorResult instead of QuerySubState * Update buildHooks test and type expectations for useLazyQuery unwrapping * Update UseLazyQueryTrigger signature * Remove extra unwrap and add queryString types * remove import, fix test Co-authored-by: Lenz Weber <mail@lenzw.de>
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
* Override unwrap behavior for buildInitiateQuery, update tests * Update TS test matrix to cover 4.4 and 4.5 * Fix type issue in tests * Update packages/toolkit/src/query/tests/buildHooks.test.tsx * Remove intermediate variable for aggregatePromise * Update packages/toolkit/src/query/core/buildInitiate.ts Co-authored-by: Lenz Weber <mail@lenzw.de> Co-authored-by: Mark Erikson <mark@isquaredsoftware.com>
The `ReducerPath` type tries to extract the generic type for "the path of the reducer" arg from `EndpointDefinitions`. However, it looks like this was always off by one: getting the 4th arg instead of the actual 5th arg. This caused bad input to the generated selectors. That seems to have worked okay with Reselect 4.0 and its looser types, but caused problems when we updated to Reselect 4.1.x and its improved types. The `RootState` type collapsed down to an empty object, because there was no valid string to use as an object key. This fixes the bug and adds a typetest to verify that the selector types are carried through all the way.
|
Let's do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current progress is tracked in this Beta Project