Support a custom paramsSerializer on fetchBaseQuery #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
requested review from
phryneas,
Shrugsy and
markerikson
and removed request for
phryneas and
Shrugsy
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 655d5ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/61605f69cfde030008e9beb5 😎 Browse the preview: https://deploy-preview-1594--redux-starter-kit-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c237581:
|
size-limit report 📦
|
|
seems very similar in spirit to the proposal in this issue: #1469 |
I didn't see that thread - I'll drop a comment there. |
Shrugsy
approved these changes
Oct 10, 2021
Remove excessive tag invalidation in examples which would otherwise interfere with the manual cache update
msutkowski
force-pushed
the
rtkq-fetchBaseQuery-paramsSerializer
branch
2 times, most recently
from
681adc1
to
ec5cfd0
Compare
msutkowski
force-pushed
the
rtkq-fetchBaseQuery-paramsSerializer
branch
from
ec5cfd0
to
8e14a98
Compare
phryneas
approved these changes
Oct 17, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this when we originally built
fetchBaseQuery, but ran into this yesterday at work. A lot of ruby/elixir/whatever APIs natively handle a bracket params format, so in order to support this, we'd need to allow for a custom paramsSerializer as proposed.