Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up from #247, I've implemented changes for the following:
In dark mode:
In light mode:
There was also a warning with the
aria-hidden
tag on the landing page that has been fixed.Attaching a screenshot to highlight the changes for the dark mode below; I had tweak the shade of purple being used for the
code a
elements. There were infima-based vars available in thecustom.css
file, so I went ahead and used those.Since accessibility was one of the reasons that previous attempts didn't go through, I tried to make sure that there was enough contrast with the shades chosen (purple isn't easy to implement dark mode with 😅). Here's the results:
Before:
After:
Would love to see dark mode getting finally enabled for the docs, please feel free to make any tweaks/suggestions that you'd like.