Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed argument to be more descriptive of its dual nature #146

Merged
merged 1 commit into from
Jun 19, 2015
Merged

Renamed argument to be more descriptive of its dual nature #146

merged 1 commit into from
Jun 19, 2015

Conversation

johanneslumpe
Copy link
Contributor

Everybody ok with that?

@ooflorent
Copy link
Contributor

LGTM

@emmenko
Copy link
Contributor

emmenko commented Jun 19, 2015

LGTM too.

Refs #140

@johanneslumpe
Copy link
Contributor Author

/cc @gaearon @acdlite

If you guys are fine with this too I'll merge this on

ooflorent added a commit that referenced this pull request Jun 19, 2015
@ooflorent
Merge pull request #146 from gaearon/rename-redux-ctor-argument
6582910 
Renamed argument to be more descriptive of its dual nature
@ooflorent ooflorent merged commit 6582910 into master Jun 19, 2015
@ooflorent ooflorent deleted the rename-redux-ctor-argument branch June 19, 2015 08:49
@johanneslumpe
Copy link
Contributor Author

Or like this ;)

@gaearon
Copy link
Contributor

gaearon commented Jun 19, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johanneslumpe @ooflorent @emmenko @gaearon