Breaking API changes for 1.0 #195

gaearon · 2015-06-30T21:32:10Z

Naming

“Stateless Stores” are now called reducers. (Proposal: Rename "stores" to "reducers" #137 (comment))
The “Redux instance” is now called “The Store”. (Proposal: Rename "stores" to "reducers" #137 (comment))
The dispatcher is removed completely. (Remove dispatcher (WIP) #166 (comment))

API changes

~~composeStores~~ is now composeReducers.
~~createDispatcher~~ is gone.
~~createRedux~~ is now createStore.
<Provider> now accepts store prop instead of ~~redux~~.
The new createStore signature is createStore(reducer: Function | Object, initialState: any, middlewares: Array | ({ getState, dispatch }) => Array).
If the first argument to createStore is an object, composeReducers is automatically applied to it.
The “smart” middleware signature changed. It now accepts an object instead of a single getState function. The dispatch function lets you “recurse” the middleware chain and is useful for async: Time travel #113 (comment).

Correctness changes

The dispatch provided by the default thunk middleware now walks the whole middleware chain.
It is enforced now that raw Actions at the end of the middleware chain have to be plain objects.
Nested dispatches are now handled gracefully. (Gracefully handle nested dispatches #110, Stateless dispatcher #119)

Internal changes

The object in React context is renamed from ~~redux~~ to store.
Some tests are rewritten for clarity, focus and edge cases.
Redux in examples is now aliased to the source code for easier work on master.

gaearon · 2015-06-30T21:45:27Z

This PR supersedes #166, #119, and #120, and brings us much closer to 1.0 (#164).

The missing pieces for 1.0 are more strict composeReducers (#193), new docs (#140), and a more convenient action creator binding API (#86), if we are certain that we need it.

Naming: * “Stateless Stores” are now called reducers. (#137 (comment)) * The “Redux instance” is now called “The Store”. (#137 (comment)) * The dispatcher is removed completely. (#166 (comment)) API changes: * <s>`composeStores`</s> is now `composeReducers`. * <s>`createDispatcher`</s> is gone. * <s>`createRedux`</s> is now `createStore`. * `<Provider>` now accepts `store` prop instead of <s>`redux`</s>. * The new `createStore` signature is `createStore(reducer: Function | Object, initialState: any, middlewares: Array | ({ getState, dispatch }) => Array)`. * If the first argument to `createStore` is an object, `composeReducers` is automatically applied to it. * The “smart” middleware signature changed. It now accepts an object instead of a single `getState` function. The `dispatch` function lets you “recurse” the middleware chain and is useful for async: #113 (comment). Correctness changes: * The `dispatch` provided by the default thunk middleware now walks the whole middleware chain. * It is enforced now that raw Actions at the end of the middleware chain have to be plain objects. * Nested dispatches are now handled gracefully. (#110) Internal changes: * The object in React context is renamed from <s>`redux`</s> to `store`. * Some tests are rewritten for clarity, focus and edge cases. * Redux in examples is now aliased to the source code for easier work on master.

gaearon · 2015-06-30T22:02:16Z

Released on NPM as 1.0.0-alpha.

dariocravero · 2015-06-30T22:04:05Z

🎉 :)

gaearon · 2015-06-30T22:05:00Z

examples/counter/containers/CounterApp.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { bindActionCreators } from 'redux';
+import { bindActionCreators } from 'redux/index';


Whoops, this slipped in by mistake when copy-pasting.

acdlite · 2015-06-30T22:40:58Z

Yay! Looks good!

I've been wondering if composeReducers() is really the best name for that function. The name is very generic, whereas its implementation is very specific.

Consider another common way of composing reducers, which is to apply each one of them in sequence:

(...reducers) => (prevState, action) =>
  reducers.reduce(
    (state, r) => r(state, action),
    prevState
  );

This could also be named composeReducers(). (I'd actually argue this is better fit for the name.)

Maybe we should think of a more specific name? Don't have any suggestions right now, but I wonder what everyone else's thoughts are.

gaearon · 2015-06-30T22:43:32Z

@acdlite Any precedents in other libraries' APIs?

dbrans · 2015-07-01T05:53:00Z

src/middleware/thunk.js

-
-    return recurse;
-  };
+export default function thunkMiddleware({ dispatch, getState }) {


Where does the name "thunk" come from?

as in so? https://en.wikipedia.org/wiki/Thunk

https://github.com/tj/co#thunks

emmenko · 2015-07-01T07:19:47Z

@gaearon one step forward, great work! 👍

iamdustan · 2015-07-01T13:30:05Z

src/createStore.js

+  return {
+    dispatch: cookedDispatch,
+    subscribe: ::store.subscribe,
+    getState: ::store.getState,


I’m curious why a second ::store.getState function is created instead of reusing the one from #L20?

Overlooked this :-). No real reason

Breaking changes: s/atom/store

…e id

…menter Modify test case ID generation for reducer changing

rpominov · 2015-07-01T21:36:52Z

I've been wondering if composeReducers() is really the best name for that function.
Maybe we should think of a more specific name? Don't have any suggestions right now, but I wonder what everyone else's thoughts are.

combineReducers() maybe?

gaearon · 2015-07-01T22:07:14Z

I like combine.

Update counter example to recent react-redux

Unsubscribing during a dispatch would change the listeners array. However that causes the next listener not to fire.

Fixes #461 - Copy listeners array, so subscribes can't affect the loop.

Add “real world” example

…mple Update real world example to remove ES7

Fix syntax error in Object.assign in real world example

This changes 'on' to 'one' in the string 'Specify on of the exported Schemas.'

Real World Example - Fix typo in API middleware error string

Tweak example conventions

Add a simple async example

Breaking API changes for 1.0

ghost · 2015-08-14T02:28:05Z

2.5 (insanely hectic for you)months from "Initial Commit" to "1.0" is kind of crazy... Nice work :)

This was referenced Jun 30, 2015

Remove dispatcher (WIP) #166

Closed

Umbrella 1.0 #164

Closed

gaearon force-pushed the breaking-changes-1.0 branch from 9a0bc7a to 634d18e Compare June 30, 2015 21:41

This was referenced Jun 30, 2015

Stateless dispatcher #119

Closed

Pass dispatch to higher-order middleware and re-implement thunk #120

Closed

gaearon force-pushed the breaking-changes-1.0 branch from 634d18e to e426039 Compare June 30, 2015 21:52

gaearon reviewed Jun 30, 2015
View reviewed changes

Remove unnecessary changes

34d90b9

gaearon mentioned this pull request Jun 30, 2015

Throw error on undefined value from store function #193

Closed

dbrans reviewed Jul 1, 2015
View reviewed changes

iamdustan reviewed Jul 1, 2015
View reviewed changes

iamdustan mentioned this pull request Jul 1, 2015

Modify test case ID generation for reducer changing #200

Merged

iamdustan and others added 3 commits July 1, 2015 10:02

s/atom/state and s/Composition/composition

8c8e429

Merge pull request #201 from iamdustan/breaking-changes-s-atom-store

72aa974

Breaking changes: s/atom/store

state preservation when replacing a reducer: continue incrementing th…

667d8f5

…e id

gaearon mentioned this pull request Jul 1, 2015

Roadmap cloverfield-tools/universal-react-boilerplate#4

Open

20 tasks

Merge pull request #200 from iamdustan/breaking-changes-test-id-incre…

069d641

…menter Modify test case ID generation for reducer changing

gaearon and others added 25 commits August 10, 2015 21:38

Style tweaks + update react-redux

79f90bc

Add test:watch to examples

06134f7

update counter example

9db0c57

Clarify action and prop naming: mark => complete

27fa07c

Merge pull request #453 from hartzis/update-counter-example

f0132a0

Update counter example to recent react-redux

Fixes #461 - Copy listeners array, so subscribes can't affect the loop.

2ddfd71

Unsubscribing during a dispatch would change the listeners array. However that causes the next listener not to fire.

Merge pull request #462 from arian/fix-461-unsubscribing-listeners

d594232

Fixes #461 - Copy listeners array, so subscribes can't affect the loop.

Port flux-react-router-example to Redux

b94f9a8

Rename packages

df01a1f

Merge pull request #460 from gaearon/add-async-example

41e609d

Add “real world” example

Update index.js

6446dfd

remove spread from api middleware

dd2de74

prefer Object.assign

2ea278e

remove usage of static and extend from React.Component

8b5298c

Merge pull request #466 from danmartinez101/use-es6-in-real-world-exa…

889a7be

…mple Update real world example to remove ES7

Fix syntax error in Object.assign in real world example

4fba03f

Merge pull request #467 from nbostrom/fix-object-assign-in-example

30122f6

Fix syntax error in Object.assign in real world example

Real World Example - Fix typo in API middleware error string

bf349bb

This changes 'on' to 'one' in the string 'Specify on of the exported Schemas.'

Merge pull request #471 from HPate-Riptide/patch-1

8b1c075

Real World Example - Fix typo in API middleware error string

Add redux-logger

b9bb28f

Fixes pagination

ed33ec1

Tweak example conventions

4de6324

Merge pull request #473 from gaearon/tweak-example-conventions

f179ba8

Tweak example conventions

Add simple async example

01c3cf0

Merge pull request #474 from gaearon/add-async-example-2

fd7f884

Add a simple async example

gaearon added a commit that referenced this pull request Aug 14, 2015

Merge pull request #195 from gaearon/breaking-changes-1.0

6d0107e

Breaking API changes for 1.0

gaearon merged commit 6d0107e into master Aug 14, 2015

gaearon deleted the breaking-changes-1.0 branch August 14, 2015 13:31

markerikson mentioned this pull request Nov 5, 2017

Optimize dispatch plain object check #2599

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Breaking API changes for 1.0 #195

Breaking API changes for 1.0 #195

gaearon commented Jun 30, 2015

gaearon commented Jun 30, 2015

gaearon commented Jun 30, 2015

dariocravero commented Jun 30, 2015

gaearon Jun 30, 2015

acdlite commented Jun 30, 2015

gaearon commented Jun 30, 2015

dbrans Jul 1, 2015

iamdustan Jul 1, 2015

clearjs Jul 1, 2015

emmenko commented Jul 1, 2015

iamdustan Jul 1, 2015

gaearon Jul 1, 2015

rpominov commented Jul 1, 2015

gaearon commented Jul 1, 2015

ghost commented Aug 14, 2015

Breaking API changes for 1.0 #195

Breaking API changes for 1.0 #195

Conversation

gaearon commented Jun 30, 2015

Naming

API changes

Correctness changes

Internal changes

gaearon commented Jun 30, 2015

gaearon commented Jun 30, 2015

dariocravero commented Jun 30, 2015

gaearon Jun 30, 2015

Choose a reason for hiding this comment

acdlite commented Jun 30, 2015

gaearon commented Jun 30, 2015

dbrans Jul 1, 2015

Choose a reason for hiding this comment

iamdustan Jul 1, 2015

Choose a reason for hiding this comment

clearjs Jul 1, 2015

Choose a reason for hiding this comment

emmenko commented Jul 1, 2015

iamdustan Jul 1, 2015

Choose a reason for hiding this comment

gaearon Jul 1, 2015

Choose a reason for hiding this comment

rpominov commented Jul 1, 2015

gaearon commented Jul 1, 2015

ghost commented Aug 14, 2015