-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation page "Writing Custom Middleware" #4498
Add documentation page "Writing Custom Middleware" #4498
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4c651c:
|
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left some requests for tweaks
Co-authored-by: Mark Erikson <mark@isquaredsoftware.com>
Co-authored-by: Mark Erikson <mark@isquaredsoftware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed most of these. Open questions are
- how to name the pattern of a middleware modifying its return value
- whether to use the
void
convention for unawaited promises
@markerikson do you have feedback for the last two questions? |
Per the "naming" question, I think I'd just refer to it as "overriding" or "replacing" the return value. |
@markerikson I've rewritten the standard examples with concrete examples from rtk. |
@markerikson any feedback? |
Okay, let's go with this. Thanks! |
Fixes #4472
name: 📖 New/Updated Documentation Content
about: Adding a new docs page, or updating content in an existing docs page
PR Type
Add a page
Checklist
What docs page is being added or updated?
For Adding New Content
What kind of content category is this page (tutorial, how-to, explanation, reference)?
How-to
Who is the intended target audience?
Developers thinking about writing their own middleware with low to medium experience with Redux.
What knowledge are we assuming they have?
How to use Redux and middleware in general, but not how to write middleware.
What are the intended results or takeaways from reading this page?
What is the most critical info they should learn?