fix(prerender): Fold output to prevent crashing on large prerender counts #10888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Jun 28, 2024
Tobbe
approved these changes
Jun 28, 2024
Josh-Walker-GM
added a commit
that referenced
this pull request
Jun 28, 2024
…unts (#10888) **Problem** A user highlighted on our [forum](https://community.redwoodjs.com/t/prerender-maximum-callstack-size-exceeded/7256) that when you prerender a large number of routes the CLI crashes. This appears to be a result of having too many Listr tasks in our CLI output. **Changes** 1. If the number of routes for a particular route is beyond some threshold we fold the output into one task. Instead of showing each individual route we show the route's name a progress indicator.
Josh-Walker-GM
added a commit
that referenced
this pull request
Jun 28, 2024
…unts (#10888) **Problem** A user highlighted on our [forum](https://community.redwoodjs.com/t/prerender-maximum-callstack-size-exceeded/7256) that when you prerender a large number of routes the CLI crashes. This appears to be a result of having too many Listr tasks in our CLI output. **Changes** 1. If the number of routes for a particular route is beyond some threshold we fold the output into one task. Instead of showing each individual route we show the route's name a progress indicator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A user highlighted on our forum that when you prerender a large number of routes the CLI crashes.
This appears to be a result of having too many Listr tasks in our CLI output.
Changes