Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted FatalErrorBoundary to typescript #1273

Merged
merged 5 commits into from
Oct 10, 2020
Merged

converted FatalErrorBoundary to typescript #1273

merged 5 commits into from
Oct 10, 2020

Conversation

shzmr
Copy link
Contributor

@shzmr shzmr commented Oct 5, 2020

Converted web/src/components/FatalErrorBoundary to .tsx file

@thedavidprice
Copy link
Contributor

Thanks @shzmr 🚀

References #1217

@kimadeline Wanted to confirm you didn't already have this in process. If not, would you feel comfortable helping Review on this one and/or giving some initial feedback on the approach based on work you and Peter are doing?

Copy link
Contributor

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂 Thank you for your help @shzmr!

@thedavidprice
Copy link
Contributor

Hi all! Thanks again for the help here.

I'm adding this to Peter's review list (when he's back next week) to be included in the v0.20.0 release.

Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@peterp peterp added this to the Next release milestone Oct 10, 2020
@peterp peterp merged commit 20258d5 into redwoodjs:main Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants