Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥮 @redwood/web typing: Add types to RedwoodProvider #1291

Merged
merged 9 commits into from
Oct 10, 2020
Merged

🥮 @redwood/web typing: Add types to RedwoodProvider #1291

merged 9 commits into from
Oct 10, 2020

Conversation

kimadeline
Copy link
Contributor

References #1217

Add types to:

  • GraphQLProviderWithAuth
  • RedwoodProvider

Had to export types from:

  • @redwoodjs/auth
  • @redwoodjs/web/src/graphql

Exported types from @redwoodjs/web/withCell as well

@kimadeline kimadeline marked this pull request as ready for review October 7, 2020 15:36
@thedavidprice
Copy link
Contributor

Thanks! Putting this on the list for Peter to review when he's back in the saddle 🐴

@thedavidprice thedavidprice mentioned this pull request Oct 8, 2020
Closed
8 tasks
@Krisztiaan Krisztiaan mentioned this pull request Oct 8, 2020
Closed
peterp
peterp approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@peterp peterp added this to the Next release milestone Oct 10, 2020
@peterp peterp merged commit a4bd3da into redwoodjs:main Oct 10, 2020
@kimadeline kimadeline deleted the 1217-redwood-provider branch October 13, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kimadeline @thedavidprice @peterp