Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetchPolicy and nextFetchPolicy to beforeQuery #1428

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Add fetchPolicy and nextFetchPolicy to beforeQuery #1428

merged 2 commits into from
Nov 4, 2020

Conversation

cannikin
Copy link
Member

@cannikin cannikin commented Nov 2, 2020

Closes #1427

@cannikin cannikin requested review from jtoar and peterp November 2, 2020 22:24
@thedavidprice thedavidprice added release:breaking This PR is a breaking change next release docs labels Nov 3, 2020
peterp
peterp approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amaze!

@peterp
Copy link
Contributor

peterp commented Nov 3, 2020

Is this a breaking change?

@cannikin cannikin mentioned this pull request Nov 4, 2020
Closed
@cannikin
Copy link
Member Author

cannikin commented Nov 4, 2020

I don't think so? If you had written your own cache-management code I don't think this would affect it.
Although it would add a network request to refresh the cache when one technically isn't needed. But that was also the behavior pre-0.20.0.

@cannikin cannikin merged commit 0661533 into main Nov 4, 2020
@cannikin cannikin deleted the rc-next-fetch-policy branch November 4, 2020 18:05
@thedavidprice thedavidprice added this to the Next release milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

@jtoar jtoar Awaiting requested review from jtoar

Assignees
No one assigned
Labels
release:breaking This PR is a breaking change
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

Emulate original cache-and-network Apollo behavior
3 participants
@cannikin @peterp @thedavidprice