@redwoodjs/forms: Convert to TS #1431
Conversation
Tobbe
force-pushed
the
tobbe-ts-forms
branch
4 times, most recently
from
07e414c
to
50cdd57
Compare
Tobbe
force-pushed
the
tobbe-ts-forms
branch
2 times, most recently
from
ded0faf
to
8c3eb2d
Compare
Tobbe
changed the title
|
Tried it with the form from the tutorial. Still works like it's supposed to. |
|
@peterp Ready for review! |
| setCoercions: React.Dispatch<React.SetStateAction<Coercions>> | ||
| } | ||
|
|
||
| const CoercionContext = React.createContext({} as CoercionContextInterface) |
There was a problem hiding this comment.
Since we don't have default values for this context, we can do something like this:
React.createContext<Partial<CoercionContext>>({});https://fettblog.eu/typescript-react/context/#context-without-default-values
There was a problem hiding this comment.
I don't want to do this. It's effectively make all attributes of the context optional, which I don't want. We actually do have kind of "default values". They're just not set here. They're set further down as props to the Provider. Whatever you put here is never going to be used. It's only for when you use the context outside of its Provider, which we never do.
There was a problem hiding this comment.
That's fair. We're not trying to satisfy TS here... but rather our intention.
|
@Tobbe This is great, thanks! |
I have some TODOs left in the code that I need to clear up