create_pr_package: Unique names per build #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-pr-package-unique-name
branch
from
2f784f0
to
5a58b1b
Compare
|
Nice, I think eventually we should try to make these easier to install via a CLI, and then we can just tell people to run the command:
Or something :) |
|
Yes, cli support for this would be awesome. Is there anything else/more you want me to do for this PR though, before it can be merged? |
|
@Tobbe Nope, sorry, ship it! |
peterp
approved these changes
Nov 19, 2020
Tobbe
force-pushed
the
tobbe-pr-package-unique-name
branch
from
5a58b1b
to
a410bd3
Compare
Tobbe
force-pushed
the
tobbe-pr-package-unique-name
branch
from
a410bd3
to
a274503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included the sha-1 of the commit in the filename to make it more deterministic what package (code) you install and deploy. There is still only one comment from the bot with the filenames. Each time a new commit comes on on the PR the comment is updated. You can always see past comments (with the old filenames) by using the dropdown on the comment, see screenshot. The screenshot also shows that the first 7 characters of the commit sha-1 are included in the package filenames
/cc @jeliasson