-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unix socket or port for functions server #1689
Support unix socket or port for functions server #1689
Conversation
This is awesome, thanks! |
@peterp I missed putting the |
As a follow-on to this, I've got the bare bones of a guide for running Redwood on Heroku here: https://gist.github.com/brentjanderson/dcb59c46023c67c44eb12492b038ff84 I've got it working on an internal app built with Redwood and running on Heroku. I haven't had someone try and use those instructions themselves yet to proof that they're workable, but it's pretty straightforward once this PR lands and if you add in the right pieces for heroku (Nginx conf file, Procfile, app.json, build/start script, etc.) Comments there welcome - I'll drop a note on the forum as well for feedback. |
Great idea! 👍 |
…ender-p1 * 'main' of github.com:redwoodjs/redwood: Updated Status of Storybook in Technologies Fix import in RWProject in rw/structure (redwoodjs#1707) Support unix socket or port for functions server (redwoodjs#1689) Don't run PR build actions on forks (redwoodjs#1712) Router: Explicitly build types (redwoodjs#1722) Router: Automatically import .ts Page files Fix env loading in users webpack config (redwoodjs#1729) Format import-dir-*-.d.ts Format generated routes.d.ts file CRWA Readme: Add missing comma (redwoodjs#1715) Corrects dataMigrate install instructions (redwoodjs#1718)
I'm trying to get instructions together to run Redwood on Heroku. Given that half of the app runs as a statically built site and the other half runs with
@redwoodjs/api-server
, I'm planning on doing the following:yarn rw build
release
phase that runsyarn rw db up
web
HTMLThis PR enables step 3. If you specify
--socket
then it will mount it on that local socket instead of a given port. On process exit, we clean up the socket. The other changes would be made by teams wanting to deploy to heroku.