Don't run PR build actions on forks #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-pr-repo-check
branch
from
f3a4d7c
to
70f2aca
Compare
thedavidprice
approved these changes
Feb 4, 2021
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 5, 2021
…ender-p1 * 'main' of github.com:redwoodjs/redwood: Updated Status of Storybook in Technologies Fix import in RWProject in rw/structure (redwoodjs#1707) Support unix socket or port for functions server (redwoodjs#1689) Don't run PR build actions on forks (redwoodjs#1712) Router: Explicitly build types (redwoodjs#1722) Router: Automatically import .ts Page files Fix env loading in users webpack config (redwoodjs#1729) Format import-dir-*-.d.ts Format generated routes.d.ts file CRWA Readme: Add missing comma (redwoodjs#1715) Corrects dataMigrate install instructions (redwoodjs#1718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you fork a repo you get all the repo's actions as well. That means the PR build and publish actions will run. But they'll fail because they don't have access to the S3 bucket secret (which is as it should be). So there really is no point in running these on any other repo than redwoodjs/redwood
Thanks to @jeliasson for the idea!