Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects dataMigrate install instructions #1718

Merged

Conversation

dthyresson
Copy link
Contributor

Fix: #1717

Data Migrate Command: dataMigrate install refers to yarn rw db up when it should refer to yarn rw dataMigrate up

When running the command yarn rw dataMigrate install:

... dataMigrate install
  ✔ Creating dataMigrations directory...
  ✔ Adding RW_DataMigration model to schema.prisma...
  ✔ Create db migration...
  ✔ Next steps:
    Don't forget to apply your migration when ready:

      yarn rw db up

✨  Done in 6.17s.

However, the message should be:

yarn rw dataMigrate up

as that is the instruction after creating a dataMigration file:

 ✔ Generating data migration file...
    ✔ Successfully wrote file `./api/prisma/dataMigrations/20210203150029-some-migration.js`
  ✔ Next steps...

    After writing your migration, you can run it with:

      yarn rw dataMigrate up

This PR changes the POST_INSTALL_INSTRUCTIONS to refer to yarn rw dataMigrate up instead.

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

@thedavidprice thedavidprice merged commit 5eb3f8b into redwoodjs:main Feb 3, 2021
@thedavidprice thedavidprice added this to the next release milestone Feb 3, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Feb 5, 2021
…ender-p1

* 'main' of github.com:redwoodjs/redwood:
  Updated Status of Storybook in Technologies
  Fix import in RWProject in rw/structure (redwoodjs#1707)
  Support unix socket or port for functions server (redwoodjs#1689)
  Don't run PR build actions on forks (redwoodjs#1712)
  Router: Explicitly build types (redwoodjs#1722)
  Router: Automatically import .ts Page files
  Fix env loading in users webpack config (redwoodjs#1729)
  Format import-dir-*-.d.ts
  Format generated routes.d.ts file
  CRWA Readme: Add missing comma (redwoodjs#1715)
  Corrects dataMigrate install instructions (redwoodjs#1718)
@dthyresson dthyresson deleted the dt-data-migrate-instruction-up-fix branch December 23, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants