Router: Explicitly build types #1722
Conversation
|
Do we need any other approval on this? edit --> adding @peterp review now. Peter, having just gone through our local build and publishing build process, want to make sure there's not a specific reason for the current setup. Assuming not. |
|
@thedavidprice I think it's fine to merge this. It was just I who missed adding the ttsc command when I rewrote everything in TS. All the other TS packages has it, so this one should too. So just an oversight on my part. If you still want to wait for Peter's approval that's 100% fine, but if you want to go ahead and merge this I think that should be fine too. |
|
Roger that and background makes sense! When publishing, we handle TS build separately so it was already being included. I’ll get this one in. Thanks! |
…ender-p1 * 'main' of github.com:redwoodjs/redwood: Updated Status of Storybook in Technologies Fix import in RWProject in rw/structure (redwoodjs#1707) Support unix socket or port for functions server (redwoodjs#1689) Don't run PR build actions on forks (redwoodjs#1712) Router: Explicitly build types (redwoodjs#1722) Router: Automatically import .ts Page files Fix env loading in users webpack config (redwoodjs#1729) Format import-dir-*-.d.ts Format generated routes.d.ts file CRWA Readme: Add missing comma (redwoodjs#1715) Corrects dataMigrate install instructions (redwoodjs#1718)
Makes type generation run when you manually build just the router package. See this comment for more context #1641 (comment)