Fixes to crwa template for prerender #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dac09
commented
Feb 19, 2021
dac09
commented
- Fix entry js, not sure when rootElement went missing!
- Make index a little more readable, as it confuses people with the export default function
|
@peterp we broke something during our review 😅 |
Tobbe
approved these changes
Feb 19, 2021
|
Merging this peter, to unblock testing. We can discuss when you're back online! :) |
|
Whoops, I made these changes, do we need rootElement? I can't really understand how these changes break things? |
|
@peterp See lines 14 and 16? It's used there |
|
(Had this been TS it wouldn't even have compiled, just sayin... 😉) |
| */ | ||
| if (document.getElementById('redwood-app').hasChildNodes()) { | ||
| */ | ||
| const rootElement = document.getElementById('redwood-app') |
There was a problem hiding this comment.
Yep, I was wondering about that!
There was a problem hiding this comment.
Thanks for the tip @thedavidprice. They don't call you el David for no reason!
There was a problem hiding this comment.
lulz
I kinda want that on a hat
Could not agree with you more |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 22, 2021
…rib-workspaces * 'main' of github.com:redwoodjs/redwood: Lint the create-redwood-app template. (redwoodjs#1822) Update typescript lint rule for no-unused-vars (redwoodjs#1808) Router: Fix TS types (redwoodjs#1823) Generate globals for routes (redwoodjs#1744) Ethereum auth update to v0.2.1 (redwoodjs#1807) Better messages when no routes marked with prerender (redwoodjs#1821) Feature/prerender image support (redwoodjs#1721) Fix entry js | Make index a little more readable, as it confuses people (redwoodjs#1819) use 'prisma' in place of '@prisma/cli' (redwoodjs#1800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.