Better messages when no routes marked with prerender #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterp
approved these changes
Feb 19, 2021
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 22, 2021
…rib-workspaces * 'main' of github.com:redwoodjs/redwood: Lint the create-redwood-app template. (redwoodjs#1822) Update typescript lint rule for no-unused-vars (redwoodjs#1808) Router: Fix TS types (redwoodjs#1823) Generate globals for routes (redwoodjs#1744) Ethereum auth update to v0.2.1 (redwoodjs#1807) Better messages when no routes marked with prerender (redwoodjs#1821) Feature/prerender image support (redwoodjs#1721) Fix entry js | Make index a little more readable, as it confuses people (redwoodjs#1819) use 'prisma' in place of '@prisma/cli' (redwoodjs#1800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It's easy to forget to add the
prerenderprop to Routes, and think "it doesnt work"This gives you a little bit more feedback to tell you why prerender isn't doing anything
What it looks like ->
https://s.tape.sh/WOvtCoCu