Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma: use new 'prisma' package to replace '@prisma/cli' #1800

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

thedavidprice
Copy link
Contributor

Prisma has deprecated @prisma/cli in favor of the new prisma package. In previous testing, the new package caused Vercel deploys to fail due to deployed GraphQL.js function being > 50Mb. (Note: I have no idea why nor has anyone else been able to explain the cause to me.) Vercel has been testing a different built tool and is now ready for a trial run with the new Prisma prisma package.

I'll be using the PR packages for Vercel deployment tests.

@github-actions
Copy link

github-actions bot commented Feb 17, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/create-redwood-app-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-api-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-api-server-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-auth-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-cli-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-core-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-dev-server-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-eslint-config-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-eslint-plugin-redwood-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-forms-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-internal-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-prerender-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-router-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-structure-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-testing-0.25.1-eccee48.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1800/redwoodjs-web-0.25.1-eccee48.tgz

Install this PR by running yarn rw upgrade --pr 1800:0.25.1-eccee48

@peterp
Copy link
Contributor

peterp commented Feb 18, 2021

I'm assuming if this works that you'll want to merge this?

@thedavidprice
Copy link
Contributor Author

Ran the final tests with Vercel's updated build process = ✅

Merging this now! If anything to get rid of the annoying output that reads like an error in logs and console commands:
Screen Shot 2021-02-18 at 11 40 28 AM

@thedavidprice thedavidprice merged commit 4cd6c74 into main Feb 18, 2021
@thedavidprice thedavidprice deleted the dsp-test-new-prisma-package branch February 18, 2021 19:42
@thedavidprice thedavidprice changed the title Deploy Test: use new 'prisma' package replacing '@prisma/cli' Prisma: use new 'prisma' package to replace '@prisma/cli' Feb 18, 2021
@thedavidprice thedavidprice added this to the next release milestone Feb 18, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Feb 19, 2021
…dwood into feature/prerender-image-support

* 'feature/prerender-image-support' of github.com:dac09/redwood:
  Update yarn.lock
  use 'prisma' in place of '@prisma/cli' (redwoodjs#1800)
dac09 added a commit to dac09/redwood that referenced this pull request Feb 22, 2021
…rib-workspaces

* 'main' of github.com:redwoodjs/redwood:
  Lint the create-redwood-app template. (redwoodjs#1822)
  Update typescript lint rule for no-unused-vars (redwoodjs#1808)
  Router: Fix TS types (redwoodjs#1823)
  Generate globals for routes (redwoodjs#1744)
  Ethereum auth update to v0.2.1 (redwoodjs#1807)
  Better messages when no routes marked with prerender (redwoodjs#1821)
  Feature/prerender image support (redwoodjs#1721)
  Fix entry js | Make index a little more readable, as it confuses people (redwoodjs#1819)
  use 'prisma' in place of '@prisma/cli' (redwoodjs#1800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants