Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router: Fix TS types #1823

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Router: Fix TS types #1823

merged 1 commit into from
Feb 19, 2021

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Feb 19, 2021

Adds support for the prerender prop on routes, and fixes the type for notfound

@github-actions
Copy link

github-actions bot commented Feb 19, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/create-redwood-app-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-api-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-api-server-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-auth-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-cli-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-core-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-dev-server-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-eslint-config-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-eslint-plugin-redwood-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-forms-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-internal-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-prerender-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-router-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-structure-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-testing-0.25.1-41f108e.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1823/redwoodjs-web-0.25.1-41f108e.tgz

Install this PR by running yarn rw upgrade --pr 1823:0.25.1-41f108e

@Tobbe Tobbe requested a review from dac09 February 19, 2021 21:17
Copy link
Collaborator

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Forgot about this one

@Tobbe
Copy link
Member Author

Tobbe commented Feb 19, 2021

Thanks for the quick review @dac09. Thought I was going to have to wait until Monday 🙂

@thedavidprice thedavidprice added this to the next release milestone Feb 20, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Feb 22, 2021
…rib-workspaces

* 'main' of github.com:redwoodjs/redwood:
  Lint the create-redwood-app template. (redwoodjs#1822)
  Update typescript lint rule for no-unused-vars (redwoodjs#1808)
  Router: Fix TS types (redwoodjs#1823)
  Generate globals for routes (redwoodjs#1744)
  Ethereum auth update to v0.2.1 (redwoodjs#1807)
  Better messages when no routes marked with prerender (redwoodjs#1821)
  Feature/prerender image support (redwoodjs#1721)
  Fix entry js | Make index a little more readable, as it confuses people (redwoodjs#1819)
  use 'prisma' in place of '@prisma/cli' (redwoodjs#1800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants