Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes marshalling datetimes in and out of forms #1906

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Conversation

cannikin
Copy link
Member

@cannikin cannikin commented Mar 4, 2021

Two parts:

  1. if you're using a <DateField> or <DatetimeLocalField> form element, the data will be coersed into the proper format (yyyy-mm-ddThh:mm:ss.sssZ) before sending through GraphQL
  2. when using the scaffold generator, datetimes are formatted properly before being set as the defaultValue prop in <DatetimeLocalField> (yyyy-mm-ddThh:mm)

Closes #1457

@github-actions
Copy link

github-actions bot commented Mar 4, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/create-redwood-app-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-api-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-api-server-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-auth-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-cli-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-core-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-dev-server-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-eslint-config-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-eslint-plugin-redwood-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-forms-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-internal-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-prerender-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-router-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-structure-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-testing-0.26.2-e1f6e2c.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1906/redwoodjs-web-0.26.2-e1f6e2c.tgz

Install this PR by running yarn rw upgrade --pr 1906:0.26.2-e1f6e2c

@cypress
Copy link

cypress bot commented Mar 4, 2021



Test summary

8 0 0 0


Run details

Project RedwoodJS Framework
Status Passed
Commit 2338a9c ℹ️
Started Mar 4, 2021 6:38 PM
Ended Mar 4, 2021 6:39 PM
Duration 01:27 💡
OS Linux Ubuntu - 16.04
Browser Chrome 88

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cannikin cannikin merged commit f39a8bb into main Mar 4, 2021
@cannikin cannikin deleted the rc-coerce-datetime branch March 4, 2021 18:53
dac09 added a commit to dac09/redwood that referenced this pull request Mar 4, 2021
…e/port-test-2-js

* 'e2e/port-test-2-js' of github.com:dac09/redwood:
  Fixes marshalling datetimes in and out of forms (redwoodjs#1906)
@peterp peterp added this to the next release milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DateTime to transformValue in forms
2 participants