fix(babel): API side include babel runtime as deps | Bump babel #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
commented
Aug 9, 2021
| @@ -10,7 +10,7 @@ | |||
| "types": "./dist/index.d.ts", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@clerk/clerk-sdk-node": "^0.5.1", | |||
There was a problem hiding this comment.
This must have been an accident right @dthyresson
thedavidprice
approved these changes
Aug 9, 2021
|
Sweet, yeah will ask DT to take for a spin and fix if there are issues! |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 12, 2021
…om-functions-test * 'main' of github.com:redwoodjs/redwood: webpack and misc upgrades (redwoodjs#3235) upgrade Prisma v2.29.0 (redwoodjs#3233) Fix API sourcemaps (babel+esbuild) for debugging (redwoodjs#3230) set canary as default (redwoodjs#3228) Fix issue where Clerk client is sometimes unset (redwoodjs#3224) Fix: Custom auth provider Private route redirect (redwoodjs#2872) fix(babel): API side include babel runtime as deps | Bump babel (redwoodjs#3220)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3216
Close this after too https://github.com/redwoodjs/redwoodjs.com/issues/766
What does it do?
A: Adds babel/runtime to api package deps
We're using @babel/plugin-transform-runtime as a framework dep, used at BUILD time.
In the docs
but in a small section they also mention:
B: Updates all babel deps to latest patch/minor
(introduces typescript const enum support!!)
C: Removes clerk auth from api package dep
Re-organises how clerk sdk gets imported, so that we don't need to have it as a redwoodjs/api dependency