Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling at FatalErrorBoundary #486

Merged
merged 2 commits into from
May 8, 2020

Conversation

thedavidprice
Copy link
Contributor

Fixes #140

Adds the Webpack Plugin 'ErrorOverlayPlugin':
https://github.com/smooth-code/error-overlay-webpack-plugin

Error display before:

Something went wrong

Error display after:

Screen Shot 2020-04-29 at 8 59 51 PM

@mojombo
Copy link
Contributor

mojombo commented Apr 30, 2020

Nice! What’s the behavior in production? We need to ensure this info doesn’t leak in that environment.

@thedavidprice
Copy link
Contributor Author

The plugin states by default it's "development ENV only" but I'd like to test it. I first wanted to see if Peter agrees with this plugin/implementation, but your question was also on my mind.

If this is the path forward, I’ll make sure we test in a Production environment before releasing it.

@peterp
Copy link
Contributor

peterp commented May 3, 2020

Nice! Tom makes a good point, maybe we should only import it in core/webpack.development.js?

Other than that the implementation is great.

@peterp peterp added this to the next release milestone May 3, 2020
@thedavidprice
Copy link
Contributor Author

@peterp moved settings to webpack dev config. Please go ahead and merge if it all's good.

@thedavidprice thedavidprice merged commit 7d1840a into master May 8, 2020
@thedavidprice thedavidprice deleted the dsp-improve-fatalerrorboundry-errors-display branch May 8, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show JS errors on FatalError page in dev mode.
3 participants