Add console log on rebuild complete #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterp
approved these changes
May 3, 2020
packages/dev-server/src/main.ts
Outdated
| @@ -187,6 +187,7 @@ const reloadLambdas = () => { | |||
| console.log('Change detected, rebuilding...') | |||
| purgeRequireCache() | |||
| lambdaFunctions = requireLambdaFunctions(PATH) | |||
| console.log(`rebuild completed. Listening again on ${HOSTNAME}`) | |||
There was a problem hiding this comment.
I don't know if adding the hostname again is helpful. Something like a timestamp for how long it took would be interesting.
|
Btw, thanks so much for this! |
vikotar
force-pushed
the
chore/rebuild_console_log
branch
from
a7eafb6
to
bc4f1d4
Compare
|
@peterp updated the code with suggested changes. It's much better now. Thanks for the suggestion. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while following along the redwood tutorial on youtube, I found that we are not logging something after the rebuild. I kept looking on the screen.xD. Then I just tried the request. and it worked.
A console log on rebuild complete might be helpful for people when they are looking in the terminal for the build processes.
Let me know if something is off or it needs further improvement. thanks!!
attaching screenshots for better understanding.
**before the console log it looks like this.
** after putting the console log it looks like this.
