Correct highlighted lines and wrap <comment>s in React fragment in tutorial chapter 6
#5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid invalid JSX element array, similar to redwoodjs#5020
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Philzen
force-pushed
the
minor-tutorial-chapter-6-fixes
branch
from
55b3543
to
d44c793
Compare
Going to add this back for now since it's used in the example
jtoar
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Name says it all – see the commit messages for explanation and references.
Regarding e597b60 – this root cause this currently doesn't need to be highlighted is #5060, which i believe may be unwanted behaviour. So i may as well drop that commit again.