Adds all input type Field form helpers #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait... did you break the CI?? |
|
Yeah what happened to the logs? It doesn’t show anything happening. :( I got an email like 30 minutes after my first commit that ESLint didn’t like something, but since then I can’t see anything in the Checks tab... |
|
@peterp did you get a chance to look at adding that Babel plugin you mentioned? Thanks dude! |
peterp
force-pushed
the
master
branch
6 times, most recently
from
711c520
to
2341368
Compare
|
After mush gnashing of teeth we found we can't do the easy export statement the way we hoped. We have to list the name of every function manually. Ugh. |
jmreidy
pushed a commit
to jmreidy/redwood
that referenced
this pull request
May 30, 2020
* Adds all input typesCloses redwoodjs#510 * Adds comments and docs * More docs * Simplify function creation * Disable eslint on useFormContext call * Fixes exports Co-authored-by: Rob Cameron <rob.cameron@fastmail.com> Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the ones we already had (Hidden, Text, Checkbox, Radio) and adds all the others found here: https://www.w3schools.com/html/html_form_input_types.asp
It uses a bit of metaprogramming—it uses the input types in a loop to create the component definitions on the fly and then assigns them to an object. The only downside is that you can't dynamically export all the objects, you need to name each and every one manually. :(