Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update jest monorepo to v28 (major) #5330

Merged
merged 10 commits into from
Aug 9, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 25, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/jest 27.5.2 -> 28.1.6 age adoption passing confidence
babel-jest 27.5.1 -> 28.1.3 age adoption passing confidence
jest (source) 27.5.1 -> 28.1.3 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Apr 25, 2022
@renovate renovate bot assigned jtoar Apr 25, 2022
@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 615bb33
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62f1bcc45158f30009420f7c

@jtoar jtoar marked this pull request as draft April 25, 2022 14:53
@renovate renovate bot force-pushed the renovate/major-jest-monorepo branch from 45e3309 to 5d45848 Compare April 25, 2022 15:43
@renovate renovate bot changed the title chore(deps): update dependency jest to v28 fix(deps): update jest monorepo to v28 (major) Apr 25, 2022
@renovate renovate bot force-pushed the renovate/major-jest-monorepo branch 6 times, most recently from bed61f1 to 6284167 Compare April 26, 2022 10:27
@jtoar jtoar added the release:breaking This PR is a breaking change label Apr 26, 2022
@renovate renovate bot force-pushed the renovate/major-jest-monorepo branch 17 times, most recently from 94233f5 to 29f86f5 Compare April 30, 2022 15:51
@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label May 3, 2022
@jtoar jtoar added next-release/major and removed release:chore This PR is a chore (means nothing for users) labels Jun 28, 2022
@finalight
Copy link

what's the status on this so far?

@jtoar
Copy link
Contributor

jtoar commented Jul 25, 2022

@finalight it wasn't a priority for us for a while, but we decided recently that it should be now. @thedavidprice and I will pick it up soon; expect movement on it this week or next. It's probably not too involved of an upgrade, and we certainly want the performance gains for our CI as well.

@jtoar jtoar mentioned this pull request Jul 28, 2022
18 tasks
@jtoar jtoar force-pushed the renovate/major-jest-monorepo branch from a54eaef to a92fe4d Compare August 7, 2022 13:31
@nx-cloud
Copy link

nx-cloud bot commented Aug 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 615bb33. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@jtoar jtoar force-pushed the renovate/major-jest-monorepo branch from a92fe4d to 8c5576c Compare August 8, 2022 04:43
@jtoar jtoar marked this pull request as ready for review August 8, 2022 04:44
@jtoar jtoar force-pushed the renovate/major-jest-monorepo branch from 8c5576c to 8fff150 Compare August 8, 2022 04:44
@jtoar jtoar force-pushed the renovate/major-jest-monorepo branch from 0aad645 to 90a27d1 Compare August 8, 2022 15:13
@jtoar
Copy link
Contributor

jtoar commented Aug 9, 2022

Summary:

If anything causes users problems downstream, I'm guessing it would be https://jestjs.io/blog/2022/04/25/jest-28#packagejson-exports, and that would have to be handled on a case-by-case basis.

@jtoar jtoar added the fixture-ok Override the test project fixture check label Aug 9, 2022
@jtoar jtoar merged commit 94ca3bb into main Aug 9, 2022
@jtoar jtoar deleted the renovate/major-jest-monorepo branch August 9, 2022 02:03
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 9, 2022
@jtoar jtoar modified the milestones: next-release, v3.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:breaking This PR is a breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants