Update FatalErrorPage codemod to work with hybrid JS/TS projects #5366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the fatalerrorpage codemod look for an existing
FatalErrorPage.{js,tsx}
file and replaces that, instead of looking for a tsconfig.json file.Background
I just upgraded one of my RW projects from v0.45 to v0.48
I verified that it still worked after running
yarn rw upgrade
Then I applied the FatalErrorPage codemod and got this
And in my terminal I see
I noticed I had a new
FatalErrorPage.tsx
file. So now I had two error pages.Deleting the old
FatalErrorPage.js
file makes everything work again.This project of mine started its life as a JS RW project, but I've gradually been moving to TS, that's why I had a .js error page and a tsconfig.json file.