-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename pathSlashModel to model and remove path flag #559
Conversation
🚀
Or something like that. It's getting long. But still needs hint at top-level -- agreed, thoughts? |
Agreed, because I'm not sure if users would look for |
@thedavidprice new help messages for
|
@thedavidprice Barring anything else, I think this one's ready. |
Thanks for the rapid turnaround! This is good on my end. Tested locally and works 💯 @cannikin want to give it a look through before merging? |
You can still specify a path in the model, but we're no longer calling it pathSlashModel--the functionality will be revealed in the help message instead. We're also taking out the path flag here, so there's only one way to do it
This PR resolves a sub-discussion of #487, and is a continuation of #423. @thedavidprice @cannikin @antonmoiseev
The functionality introduced in #423 remains unchanged--you can still specify a path in the model, but we're no longer calling it
pathSlashModel
. Justmodel
now, and the functionality will be revealed in a help message:Output for
yarn rw g scaffold --help
We're also taking out the path flag here, so now there's only one way to do it.