Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference section to CONTRIBUTING.md #577

Merged
merged 2 commits into from
May 22, 2020
Merged

Add reference section to CONTRIBUTING.md #577

merged 2 commits into from
May 22, 2020

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 21, 2020

Follow up on @redwoodjs/redwoodjs.com #129, this PR adds a Reference section for the redwood-tools command, and links back to the CLI Reference on redwoodjs.com.

@thedavidprice One thing I'm concerned about is being too repetitive and self-referential in this doc? But since people might come straight to the Reference section, it might not be a problem to redirect them to sections earlier in the doc because it's all about finding what you want fast?

CONTRIBUTING.md Outdated
- [Installing Published Packages in Your Redwood App](#Installing-Published-Packages-in-Your-Redwood-App)
- [Running Your Redwood App's Local Server(s)](#Running-Your-Redwood-App's-Local-Server(s))
- [Releases](#Releases)
- [Contributing](#contributing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we eliminate this top-level in the TOC? Feels redundant, especially since it's below the section it's linking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally.

CONTRIBUTING.md Outdated
- [Running Your Redwood App's Local Server(s)](#running-your-redwood-apps-local-servers)
- [Releases](#releases)
- [Troubleshooting](#troubleshooting)
- [Reference](#reference)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more explicit about naming here. Maybe "CLI Reference: redwood-tools". Not sure what that does to the markdown link. But it improves findability.

@thedavidprice
Copy link
Contributor

thedavidprice commented May 22, 2020

This is looking good!

One thing I'm concerned about is being too repetitive and self-referential in this doc?

^^ no way! The current implementation shows you're thinking UX, and in this case specifically the flow/journey of the user. And it's better to that end because of the links.

@jtoar
Copy link
Contributor Author

jtoar commented May 22, 2020

@thedavidprice updated!

@thedavidprice
Copy link
Contributor

Oh, yeah... 🚢'ing it!

@jtoar are you updating the link to the section in the redwoodjs.com CLI reference doc, or should I? Assuming you are but happy to do so otherwise.

@jtoar
Copy link
Contributor Author

jtoar commented May 22, 2020

@thedavidprice Yes but I almost forgot so thank you for reminding me--coming up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants