Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic typeless InputField component #590

Merged
merged 5 commits into from
Jun 12, 2020

Conversation

gfpacheco
Copy link
Contributor

Adds a new generic typeless InputField component as per discussed here: #578

Not sure that's something you still want, and since English is not my native language I didn't even try to write any docs for it, sorry.

@cannikin
Copy link
Member

This is great, thanks! I can add the docs for it.

What do you think about the loop that generates each of the other types now returning this instead of a raw HTML <input> the way it does now? Then there's only one instance of <input> anywhere and it's inside this component.

@gfpacheco
Copy link
Contributor Author

That makes total sense! I don't know how I didn't see that earlier. I guess I still need to be more comfortable with the code, look around more and not be so scared of breaking things 😂

@cannikin
Copy link
Member

haha We break things all the time, you get used to it! 😅

@cannikin
Copy link
Member

I'll test this next week and merge, then add some docs!

@cannikin cannikin self-assigned this May 27, 2020
@cannikin cannikin merged commit 84727f3 into redwoodjs:master Jun 12, 2020
@cannikin
Copy link
Member

Took a while but it's done, thanks again!

@thedavidprice thedavidprice added this to the next release milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants