Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useLocation hook to Redwood Router #650

Merged
merged 9 commits into from
Jun 19, 2020
Merged

Add useLocation hook to Redwood Router #650

merged 9 commits into from
Jun 19, 2020

Conversation

Terris
Copy link
Contributor

@Terris Terris commented Jun 3, 2020

This PR adds a useLocation hook to Redwood Router to expose location data. Useful for creating side effects on route change (e.g. fire off analytics data or dismiss a flash message).

@peterp
Copy link
Contributor

peterp commented Jun 4, 2020

This is really cool, thank you!

@jtoar
Copy link
Contributor

jtoar commented Jun 19, 2020

@thedavidprice @peterp Just pinging this one—does it look ok to merge?

@peterp peterp changed the base branch from master to main June 19, 2020 15:33
@peterp peterp added this to the next release milestone Jun 19, 2020
@peterp peterp merged commit b312389 into redwoodjs:main Jun 19, 2020
@thedavidprice
Copy link
Contributor

Hi all, will this one require Doc updates?

@jtoar
Copy link
Contributor

jtoar commented Jun 19, 2020

Most definitely!

@Terris Terris deleted the feat-use-location-hook branch June 19, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants