Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rwt copy fix for Windows #694

Merged
merged 2 commits into from
Jun 17, 2020
Merged

rwt copy fix for Windows #694

merged 2 commits into from
Jun 17, 2020

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 14, 2020

Fixes #679

@Tobbe Tobbe marked this pull request as draft June 14, 2020 13:42
@Tobbe
Copy link
Member Author

Tobbe commented Jun 14, 2020

Need to make sure this works with PowerShell as well before merging

@Tobbe Tobbe force-pushed the tobbe-rsync branch 3 times, most recently from 3a7383e to 54ec91e Compare June 15, 2020 17:14
@Tobbe Tobbe marked this pull request as ready for review June 15, 2020 17:17
@thedavidprice thedavidprice mentioned this pull request Jun 15, 2020
Closed
@Tobbe Tobbe force-pushed the tobbe-rsync branch 2 times, most recently from 5af1d59 to 0f416f2 Compare June 16, 2020 07:09
@peterp peterp self-assigned this Jun 16, 2020
@thedavidprice
Copy link
Contributor

Changes to CONTRIBUTING.md with link to blog post == ✅ Thanks @Tobbe!

@peterp I leave this one to you for merging.

@peterp peterp added this to the next release milestone Jun 17, 2020
@peterp peterp merged commit e247bc2 into redwoodjs:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

Assignees

@peterp peterp

Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

yarn rwt copy depends on rsync, which isn't available on Windows
3 participants
@Tobbe @thedavidprice @peterp