Add cache-and-network fetchPolicy to beforeQuery #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is now the default I think it's fine to remove it from the scaffolds! |
|
@cannikin Removed it from the scaffolds; ready to merge if you approve! |
cannikin
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #717 by changing
beforeQuery'sfetchPolicyto'cache-and-network'(previously, it didn't have one).Was working on the Cells doc (https://github.com/redwoodjs/redwoodjs.com/pull/202) and found #717 in the process of documenting. Figured I'd close it out real quick because it seemed simple enough (is it this simple?).
There could also be complementary PRs to remove the export of
beforeQueryin scaffolds (as it wouldn't differ from just the default after this gets merged). Or is it better to be explicit?